Dynamic alignment computation for SIMD error functions #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
jeongseok-meta
force-pushed
the
export-D63658278
branch
from
a2ce2cb
to
4376b20
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
jeongseok-meta
added a commit
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: #90 Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
jeongseok-meta
force-pushed
the
export-D63658278
branch
from
4376b20
to
db0b7b5
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
db0b7b5
to
fbdd67a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
fbdd67a
to
f93eedb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
f93eedb
to
2c572f1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
2c572f1
to
4dd0812
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
4dd0812
to
1b73203
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
1b73203
to
5d30cc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
5d30cc3
to
2b06e87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
2b06e87
to
4f952cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
Summary: Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via DrJit at compile-time, ensuring compatibility across different SIMD instruction sets. Detailed changes: - Add constants for packet sizes and alignment sizes for both DrJit and AVX versions, rather than using magic numbers - Centralize `checkAlignment()` - Fix `getJacobianSize()` for both DrJit and AVX versions, correctly utilizing the package size - Update tests to check around the number of constraints around the package size to ensure the new `getJacobianSize()` works - Update GitHub CI to test both SIMD-enabled and disabled NOTE: This Diff the second trial of D47103616 Differential Revision: D63658278
facebook-github-bot
force-pushed
the
export-D63658278
branch
from
4f952cc
to
a2f34cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63658278 |
|
This pull request has been merged in 6d8f901. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, a static alignment value of 32 was used for AVX in SIMD implementations. This diff modifies this approach to dynamically determine the correct alignment value via Enoki at compile-time, ensuring compatibility across different SIMD instruction sets.
NOTE: This Diff the second trial of D47103616
Differential Revision: D63658278